Skip to content

Work-around for core-js issue parsing headers#852

Merged
JakeChampion merged 1 commit intoJakeChampion:masterfrom
steveworkman:bugfix/core-js-3-6
Oct 13, 2020
Merged

Work-around for core-js issue parsing headers#852
JakeChampion merged 1 commit intoJakeChampion:masterfrom
steveworkman:bugfix/core-js-3-6

Conversation

@steveworkman
Copy link
Copy Markdown
Contributor

@steveworkman steveworkman commented Oct 9, 2020

Fixes #748 - as discussed in the ticket, this change avoids the use of split via regex, swapping it out for less efficient, but functional ES5 code

//cc @JakeChampion

@JakeChampion JakeChampion merged commit 61372fd into JakeChampion:master Oct 13, 2020
@eatsjobs
Copy link
Copy Markdown

eatsjobs commented Nov 5, 2020

I can't found this code in the 3.4.1. has been removed?

@steveworkman
Copy link
Copy Markdown
Contributor Author

This code has not been put into a release yet

@JakeChampion
Copy link
Copy Markdown
Owner

It's now in 3.5.0 -- https://github.com/github/fetch/releases/tag/v3.5.0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IE 11 vs preProcessedHeaders.split(/\r?\n/)

3 participants