Make Response.arrayBuffer() always resolve with a ArrayBuffer#816
Merged
JakeChampion merged 2 commits intomasterfrom Jul 31, 2020
Merged
Make Response.arrayBuffer() always resolve with a ArrayBuffer#816JakeChampion merged 2 commits intomasterfrom
ArrayBuffer#816JakeChampion merged 2 commits intomasterfrom
Conversation
freund17
reviewed
Jul 31, 2020
freund17
left a comment
There was a problem hiding this comment.
I'm not familiar with the code base, but maybe it is a better idea to convert the view to a buffer, where it is set instead of where it is used.
Because there might be other places where code is expecting an ArrayBuffer instead of a view.
| this.arrayBuffer = function() { | ||
| if (this._bodyArrayBuffer) { | ||
| return consumed(this) || Promise.resolve(this._bodyArrayBuffer) | ||
| consumed(this) |
There was a problem hiding this comment.
Consumed returns either undefined or a rejected Promise.
The previous code returned the rejected Promise.
This changes the original behaviour.
Was that intended?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #801