fix: Have unique error messages for xhr timeouts and errors#1380
Merged
JakeChampion merged 1 commit intoJakeChampion:masterfrom Sep 11, 2023
bitcrumb:patch-1
Merged
fix: Have unique error messages for xhr timeouts and errors#1380JakeChampion merged 1 commit intoJakeChampion:masterfrom bitcrumb:patch-1
JakeChampion merged 1 commit intoJakeChampion:masterfrom
bitcrumb:patch-1
Conversation
JakeChampion
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
xhr.onerrorandxhr.ontimeoutthrow the same error.I think it would be beneficial to have both handler emit errors with a different message. This way, applications can behave differently based on the error message. Especially since there is no such thing as a unique error code do distinguish both errors.