Skip to content

Commit e599b9e

Browse files
JaimiesJaimies
committed
feat: remove crashlytics
Same as analytics, better to avoid collecting user data.
1 parent 3bd61cc commit e599b9e

12 files changed

Lines changed: 4 additions & 78 deletions

File tree

‎.gitignore‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -172,12 +172,6 @@ atlassian-ide-plugin.xml
172172
# Mongo Explorer plugin
173173
.idea/mongoSettings.xml
174174

175-
# Crashlytics plugin (for Android Studio and IntelliJ)
176-
com_crashlytics_export_strings.xml
177-
crashlytics.properties
178-
crashlytics-build.properties
179-
fabric.properties
180-
181175
### AndroidStudio Patch ###
182176
!/gradle/wrapper/gradle-wrapper.jar
183177

‎app/build.gradle‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ plugins {
55
id 'kotlin-kapt'
66
id 'dagger.hilt.android.plugin'
77
id 'androidx.navigation.safeargs.kotlin'
8-
id 'com.google.gms.google-services'
9-
id 'com.google.firebase.crashlytics'
108
id 'com.google.android.gms.oss-licenses-plugin'
119
id 'io.gitlab.arturbosch.detekt' version '1.21.0'
1210
}
@@ -47,14 +45,9 @@ android {
4745
shrinkResources = true
4846
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
4947
signingConfig = signingConfigs.release
50-
resValue("bool", "FIREBASE_ANALYTICS_DEACTIVATED", "false")
51-
resValue("bool", "FIREBASE_CRASH_ENABLED", "true")
5248
}
5349
debug {
5450
multiDexEnabled = true
55-
ext.enableCrashlytics = false
56-
resValue("bool", "FIREBASE_ANALYTICS_DEACTIVATED", "true")
57-
resValue("bool", "FIREBASE_CRASH_ENABLED", "false")
5851
}
5952
}
6053

@@ -126,9 +119,6 @@ dependencies {
126119
implementation 'com.getkeepsafe.taptargetview:taptargetview:1.13.3'
127120
implementation "androidx.paging:paging-runtime-ktx:$Versions.paging"
128121

129-
implementation platform("com.google.firebase:firebase-bom:$Versions.firebase")
130-
implementation 'com.google.firebase:firebase-crashlytics-ktx'
131-
132122
implementation "androidx.work:work-runtime-ktx:$Versions.workManager"
133123
implementation 'com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava'
134124
implementation 'androidx.hilt:hilt-work:1.0.0'

‎app/src/main/AndroidManifest.xml‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,6 @@
4949
</intent-filter>
5050
</receiver>
5151

52-
<meta-data
53-
android:name="firebase_analytics_collection_deactivated"
54-
android:value="@bool/FIREBASE_ANALYTICS_DEACTIVATED" />
55-
56-
<meta-data
57-
android:name="firebase_crash_collection_enabled"
58-
android:value="@bool/FIREBASE_CRASH_ENABLED" />
59-
60-
<meta-data
61-
android:name="google_analytics_adid_collection_enabled"
62-
android:value="false" />
63-
6452
<provider
6553
android:name="androidx.startup.InitializationProvider"
6654
android:authorities="${applicationId}.androidx-startup"

‎app/src/main/java/com/maxpoliakov/skillapp/shared/recyclerview/ItemTouchHelper.kt‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import androidx.recyclerview.widget.ItemTouchHelper.SimpleCallback
99
import androidx.recyclerview.widget.ItemTouchHelper.UP
1010
import androidx.recyclerview.widget.RecyclerView
1111
import androidx.recyclerview.widget.RecyclerView.ViewHolder
12-
import com.maxpoliakov.skillapp.data.logToCrashlytics
1312
import com.maxpoliakov.skillapp.domain.model.MeasurementUnit
1413
import com.maxpoliakov.skillapp.domain.model.Skill
1514
import com.maxpoliakov.skillapp.domain.model.SkillGroup
@@ -143,12 +142,6 @@ class SimpleCallbackImpl(
143142
override fun clearView(recyclerView: RecyclerView, viewHolder: ViewHolder) {
144143
super.clearView(recyclerView, viewHolder)
145144

146-
if (viewHolder.absoluteAdapterPosition == -1) {
147-
logToCrashlytics(
148-
Exception("ItemTouchHelper::clearView(): viewHolder.absoluteAdapterPosition = 0; viewHolder = $viewHolder"),
149-
)
150-
}
151-
152145
viewHolder.itemView.translationZ = 0f
153146

154147
callback.onDropped(

‎build.gradle‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ buildscript {
99
classpath "org.jetbrains.kotlin:kotlin-serialization:$Versions.kotlin"
1010
classpath "androidx.navigation:navigation-safe-args-gradle-plugin:$Versions.navigation"
1111
classpath "com.google.dagger:hilt-android-gradle-plugin:$Versions.hilt"
12-
classpath 'com.google.gms:google-services:4.3.10'
13-
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.8.1'
1412
classpath 'com.google.android.gms:oss-licenses-plugin:0.10.6'
1513
}
1614
}

‎buildSrc/src/main/kotlin/Versions.kt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ object Versions {
2727

2828
const val hilt = "2.45"
2929

30-
const val firebase = "31.0.3"
31-
3230
const val gradle = "7.4.0"
3331

3432
const val mockito = "3.12.1"

‎data/build.gradle‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ dependencies {
103103
kapt 'androidx.hilt:hilt-compiler:1.0.0'
104104
implementation 'com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava'
105105

106-
implementation platform("com.google.firebase:firebase-bom:$Versions.firebase")
107-
implementation 'com.google.firebase:firebase-crashlytics-ktx'
108-
109106
implementation "com.google.android.gms:play-services-auth:$Versions.playServicesAuth"
110107

111108
implementation "com.google.http-client:google-http-client-gson:$Versions.googleHttpClient"

‎data/src/main/java/com/maxpoliakov/skillapp/data/Logging.kt‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎data/src/main/java/com/maxpoliakov/skillapp/data/backup/DBBackupCreator.kt‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.maxpoliakov.skillapp.data.backup
22

33
import com.maxpoliakov.skillapp.data.db.AppDatabase
4-
import com.maxpoliakov.skillapp.data.log
54
import com.maxpoliakov.skillapp.domain.model.BackupData
65
import com.maxpoliakov.skillapp.domain.repository.BackupCreator
76
import kotlinx.coroutines.async
@@ -19,7 +18,7 @@ class DBBackupCreator @Inject constructor(
1918
val data = createBackup()
2019
return BackupCreator.Result.Success(data)
2120
} catch (e: Exception) {
22-
e.log()
21+
e.printStackTrace()
2322
return BackupCreator.Result.Failure(e)
2423
}
2524
}

‎data/src/main/java/com/maxpoliakov/skillapp/data/backup/DBBackupRestorer.kt‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package com.maxpoliakov.skillapp.data.backup
22

33
import androidx.room.withTransaction
44
import com.maxpoliakov.skillapp.data.db.AppDatabase
5-
import com.maxpoliakov.skillapp.data.log
65
import com.maxpoliakov.skillapp.domain.model.BackupData
76
import com.maxpoliakov.skillapp.domain.repository.BackupRestorer
87
import kotlinx.serialization.decodeFromString
@@ -17,7 +16,7 @@ class DBBackupRestorer @Inject constructor(
1716
doRestore(data)
1817
return BackupRestorer.Result.Success
1918
} catch (e: Throwable) {
20-
e.log()
19+
e.printStackTrace()
2120
return BackupRestorer.Result.Failure(e)
2221
}
2322
}

0 commit comments

Comments
 (0)