Always track position/vel/accel internally#12
Closed
AndyZe wants to merge 2 commits intoJafarAbdi:pr-fix_servo_bugfrom
Closed
Always track position/vel/accel internally#12AndyZe wants to merge 2 commits intoJafarAbdi:pr-fix_servo_bugfrom
AndyZe wants to merge 2 commits intoJafarAbdi:pr-fix_servo_bugfrom
Conversation
added 2 commits
June 15, 2021 09:12
…to false and a joint is close to position limit" This reverts commit 4f01213.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always track position/vel/accel internally so there's no chance of seg faulting.
I also changed [] indexing to .at() so we can track bugs down more easily.
This works for my velocity-controlled robot. Does it work for you?