Fixing "working directory" argument of two of the three Linux "open terminal" commands#9954
Merged
Merged
Conversation
"open terminal" commands
Contributor
Author
|
Could someone with access please re-run the failed test job? I think they failed for reasons unrelated to my change (though why exactly, I didn't investigate deeply and it wasn't obvious). All runs fine locally and my change should have no effect on that (or any other) test... |
Member
|
Yes they are unrelated. That test sometimes fails randomly |
Siedlerchr
approved these changes
May 30, 2023
Member
|
@ThiloteE can you test this changes on your Linux system? I remember that you had issues with the terminal as well |
2 tasks
Member
|
I will try, but later today, don't have time now |
Member
|
Works like a charm on Linux Mint 20.3 Cinnamon (Linux kernel 5.4), which is based on the Ubuntu distribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9953
The "working directory" arguments to "gnome-terminal" and "konsole" were incorrect due to slight mis-use of ProcessBuilder, which meant they were badly formed and the terminal loaded in a default directory (most likely the user's home dir).
There are currently no tests at all for any of this functionality at a low-level (i.e., what operating system commands are called and with what args), nor any OS-specific test filtering, etc... probably because it is significant and complex to assert a running terminal's directory, especially from a unit test. Therefore, I have intentionally not attempted to add a test because doing so would require considerable refactoring of existing tests (OpenConsoleActionTest), with not much benefit -- and it still might not be possible to truly prove a terminal opens in a particular directory anyway.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)