Skip to content

Parameterized CiteKeyGeneratorTests and reduced calls to fileUpdateMonitor in Globals#9915

Merged
Siedlerchr merged 12 commits into
mainfrom
filemonitor
May 18, 2023
Merged

Parameterized CiteKeyGeneratorTests and reduced calls to fileUpdateMonitor in Globals#9915
Siedlerchr merged 12 commits into
mainfrom
filemonitor

Conversation

@calixtus

@calixtus calixtus commented May 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Just some code maintenance / quality

  • Parameterized tests for CitationKeyGenerator
  • Removed code duplication by overloading BibtexParser.create
  • Removed ImportFormatReader from Globals, now only called on demand
  • Removed superfluous calls to the themeManager var in Globals
  • Reduced calls to fileUpdateMonitor in Globals
    .
### Compulsory checks
- [ ] Change in `CHANGELOG.md` described in a way that is understandable for the average user (if applicable)
- [ ] Tests created for changes (if applicable)
- [x] Manually tested changed features in running JabRef (always required)
- [ ] Screenshots added in PR description (for UI changes)
- [ ] [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers dev: code-quality Issues related to code or architecture decisions labels May 17, 2023
@calixtus
Merge remote-tracking branch 'upstream/main' into filemonitor
2f5c512 
# Conflicts:
#	src/test/java/org/jabref/logic/importer/fileformat/BibtexParserTest.java
Siedlerchr
Siedlerchr approved these changes May 17, 2023
View reviewed changes

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the binaries, still works

@Siedlerchr Siedlerchr merged commit 00399f7 into main May 18, 2023
@Siedlerchr Siedlerchr deleted the filemonitor branch May 18, 2023 09:30
@calixtus calixtus mentioned this pull request May 21, 2023
Merged
@koppor koppor mentioned this pull request May 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@calixtus @Siedlerchr