Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

Screenshot:

Maybe "Enable smart automatic linking of files". We disable it at the General tab only, but keep following functionalities:

• Search for a file when "View PDF" is executed
• Quality -> Automatically File links

For these two features, we still need the settings below the checkbox. Hence, the new name proposal.

Should we move that checkbox below "Use regular expression search"? -- Otherwise, I would have expected, the other options would be grayed-out.

I initially thought about disabling the other options, but they are still needed. Maybe it makes sense to move it to the entry editor tab? Otherwise general would be the way to go

+1 for Entry Editor settings

Maybe even as second option, because it is important

Code-wise, it is ok for me to have the preference split among different tabs. UI vs. model...

Maybe the name of the preference should be changed to

• "Enable smart automatic search for linkable files"
• or "Show linkable files in entry editor general tab", (I prefer this one)

or something of the like, because linking only happens, once users click on the file (or press ctrl + F7 i believe) click on the "link files" button on the left side or use "Quality > Automatically set file links (F7)". Then it also would make sense to have the preference under "linked files".

This is only for the entry editor and affects the automatic linking. Manual linking is not affected

1. With "Enable smart autolinking of files", files are not linked automatically. They are only "shown" in the entry editor, but not linked.

   

   When you look at biblatex source tab, there is nothing in the file field.

2. With "smart autolinking of files" disabled, those files are not shown in the entry editor anymore.

This behaviour is ok, but it makes me believe the name of the new preference does not fit the behaviour as described above.

Maybe: Search and show unlinked files in the entry editor?

I am fine too with "show unlinked files in entry editor" as all other options start with "show" as well.