Moved position of add group button to HBox in groups panel UI#9329
Closed
DavidOWade wants to merge 1 commit into
Closed
Moved position of add group button to HBox in groups panel UI#9329DavidOWade wants to merge 1 commit into
DavidOWade wants to merge 1 commit into
Conversation
Member
|
Maybe we could have two buttons to add a new group? one with the plus at the top as proposed here and one at the bottom? |
Member
|
I put the devcall label, because the last devcall + discussion in last closed pr was opting for different solution to this issue. See #8462 (comment) |
Member
|
@DavidOWade thank you for your interest in JabRef programming. I'm very sorry you put effort in this issue, that should have normally already been marked als closed, but wasn't, since we overlooked it in koppors repo. Even though your changes look codewise good, it was not the solution the devcall in March choose. Please feel free to choose another issue to work on. Again our apologies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JabRef#529
Would fix #8398 if the community were to decide to take this proposal over its competing alternatives.
Description:
Moves the "add group" button previously at the bottom of the groups GUI panel into the horizontal icon menu at the top.
Proposed change:
Implementation:
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)