Fix for issue 8747: date field change causes an uncaught exception#9314
Fix for issue 8747: date field change causes an uncaught exception#9314huangderek02 wants to merge 9 commits into
Conversation
…s not in format" This reverts commit bd8f8c3.
…erences to the calling of DataEditor in FieldEditors
|
That is a nice improvement. Regarding invalid inputs, as biblatex supports a couple of more dates, see also #9310 ) can you try to integrate this with JabRef's date time parsing class? And please take a look at the reviewdog output (Files changed tab) |
Hello, could you help have a look at the new change by adding Date integration to the default string converter? I think the string converter provided by |
| try { | ||
| return dateFormatter.parse(string); | ||
| } catch (DateTimeParseException exception) { | ||
| } catch (Exception exception) { |
There was a problem hiding this comment.
Why did you change this to a generic exception? Exception should be always the most specfic one
|
I tested your PR and it looks good so far. Please have a look at the failing checkstyle tests and also the exception handling. |
Fixes #8747
Short Description
In library mode "biblatex", when user edits the entry's "date" field with an invalid input and clicks somewhere, an uncaught exception of null pointer occurs.
Checklist
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)UI changes (takes time to load gif images)
Before
Type invalid inputs: nothing happen
Click somewhere: an exception occured;
Press Enter: input disappears
After
Type invalid inputs: show warning icon
Click somewhere: nothing happens
Press Enter: input disappears
