Fixing capitalization in words with any dashes#9101
Closed
jvsdurso wants to merge 4 commits into
Closed
Conversation
Implementation of Multiple Condition Coverage (MCC) for isNumber method in NumericFieldComparator class
Member
|
Please provide the issue number, this pr fixes. |
calixtus
requested changes
Aug 29, 2022
calixtus
left a comment
Member
There was a problem hiding this comment.
Hi @jvsdurso , that is for you interest in jabref.
However I noticed some issues.
- changelog entry is only needed once.
- since java18 the idk works completely with utf 8. So you could probably use clear Unicode text instead of escaped characters. That would improve the readability a lot.
- also the tests seem to be very similar and probably could be parameterized.
Author
Changes were made. I think leaving the tests with zero width spaces in Unicode may be better for visualization. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9068
What: Fixing capitalization after dashes. Also covering zero width spaces. Tests were implemented too.
Why: To solve the issue #9068
Context: I'm having some classes about TDD (Test-Driven Development) and we were asked to solve an issue from JabRef. I chose to work on this one.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)