Fix issue 9068 - Fixing letter capitalization after hyphen or dash between 2 terms.#9100
Closed
Luan-Cavalcante wants to merge 3 commits into
Closed
Fix issue 9068 - Fixing letter capitalization after hyphen or dash between 2 terms.#9100Luan-Cavalcante wants to merge 3 commits into
Luan-Cavalcante wants to merge 3 commits into
Conversation
Member
|
Hi @Luan-Cavalcante , thanks for your interest in jabref and your PR. On first look are some issues with your code.
Also I noticed that you and your colleagues from programming class all tried to solve the same issue. This is a bit sad, since this leads to a lot of lost work, as we will only include one solution in the final merge. Also it will put a lot of work on us, the maintainers, to review all the PRs. We love teaching open source programming, but we do this all in our spare time along our day jobs. Thanks! |
6 tasks
Author
|
Hi, you're welcome!
Yeah, a lot of guys worked on the same issue, but I think it was because
this issue was the easiest one and the deadline was really close.
I'm sorry for making that mess in the changelog, my professor is working
with jabref for a long time to teach software testing. It's a really good
project. I am getting in touch with my professor as soon as possible, thank
you for the feedback. And good job.
Em seg., 29 de ago. de 2022 às 01:21, Carl Christian Snethlage <
***@***.***> escreveu:
… Hi @Luan-Cavalcante <https://github.com/Luan-Cavalcante> , thanks for
your interest in jabref and your PR. On first look are some issues with
your code.
- please try to match our code style requirements, so we can keep our
codebase consistent. We provide configs for Checkstyle and intellij idea.
Please follow the instructions on setting up your workspace for jabref
programming in our dev docs.
- you deleted several lines in our changelog for no reason.
- it seems like you hardcoded in some very few cases. Maybe there is
another easy way to make this more generic?
Also I noticed that you and your colleagues from programming class all
tried to solve the same issue. This is a bit sad, since this leads to a lot
of lost work, as we will only include one solution in the final merge. Also
it will put a lot of work on us, the maintainers, to review all the PRs. We
love teaching open source programming, but we do this all in our spare time
along our day jobs.
Please ask your professor to contact us, so we can talk about best
practices that work with us and other programming classes for next time.
Thanks!
—
Reply to this email directly, view it on GitHub
<#9100 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP7LOMSYIOIGGWA5DYJE7FTV3Q3DRANCNFSM573ZWT7A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
Ok, thanks. No big deal. Good luck with your studies! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What :
I implemented a change in the Word.java file so that I can capitalize titles, with the capitalize function, that have a hyphen or a dash inside two terms. Like enzyme-catalyzed.
Why :
To solve the issue [#9068].
Context:
I am currently studying tests in University and the Professor proposed a TDD application in JabRef.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)