Fix for issue 8396: filter out the empty field#8783
Merged
Conversation
Member
|
Please check the codestyle, see here for how to impot the style https://github.com/JabRef/jabref/tree/main/config |
Siedlerchr
reviewed
May 12, 2022
Siedlerchr
reviewed
May 12, 2022
Member
|
I was so free to replace your solution with a more simple one liner to get that PR in asap. |
Siedlerchr
reviewed
May 12, 2022
Siedlerchr
reviewed
May 12, 2022
koppor
approved these changes
May 12, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8396
Descripion
Fixes #8396 by filtering out the empty deprecated fields.
The issue was caused because it always returns a valid deprecated field set but didn't check whether is empty or not.
JabRef version
5.4 (latest release)
Operating system
Mac OS
Details on version and operating system
Monterey 12.2.1
Before
After
PR Checklist
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)