Fix invisible notification message#8763
Merged
Merged
Conversation
- Also restyled it a bit
Siedlerchr
reviewed
May 7, 2022
| notificationPane.hide(); | ||
| })), | ||
| Duration.seconds(5)); | ||
| Duration.seconds(10)); |
Member
There was a problem hiding this comment.
For the export I would not increase the time, 5 seconds is enough
…to 10 seconds" This reverts commit 32ecfd8.
calixtus
approved these changes
May 8, 2022
Siedlerchr
approved these changes
May 8, 2022
Member
|
Thanks again for the quick follow up and the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8761
The notification bar appeared blank because the title and the button's text had the same color as the background. I updated the CSS style to use a lighter color and restyled the overall look and feel of the notification bar.
I also changed the notification message and duration for when the library is successfully exported to match with Typora. I did this because I think Typora has a good user experience.
Light Theme
Dark Theme
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)