Skip to content

Add check for empty lines at beginning / end of block#8689

Merged
koppor merged 2 commits into
mainfrom
add-checkstyle-start-with-code-after-block
Apr 19, 2022
Merged

Add check for empty lines at beginning / end of block#8689
koppor merged 2 commits into
mainfrom
add-checkstyle-start-with-code-after-block

Conversation

@koppor

@koppor koppor commented Apr 18, 2022

Copy link
Copy Markdown
Member

We often have the issue that contributors have an empty line at the beginning of a block ({) or before at the end of a block (}). This PR adds a check for it and fixes these issues in the code base.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Apr 18, 2022
@Siedlerchr

Copy link
Copy Markdown
Member

Please also adjust the checkstyle for the reviewdog! (It's the same except for the suppression filter path)

@koppor koppor merged commit c99dfc9 into main Apr 19, 2022
@koppor koppor deleted the add-checkstyle-start-with-code-after-block branch April 19, 2022 19:52
@koppor koppor mentioned this pull request Apr 19, 2022
6 tasks
@koppor koppor restored the add-checkstyle-start-with-code-after-block branch April 19, 2022 20:03
@koppor koppor deleted the add-checkstyle-start-with-code-after-block branch April 19, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants