Skip to content

Update to gradle 7.4.2 and jdk18#8629

Merged
Siedlerchr merged 7 commits into
mainfrom
jdk18
May 9, 2022
Merged

Update to gradle 7.4.2 and jdk18#8629
Siedlerchr merged 7 commits into
mainfrom
jdk18

Conversation

@calixtus

@calixtus calixtus commented Mar 31, 2022

Copy link
Copy Markdown
Member
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers dev: build-system gradle-wrapper Pull requests that update Gradle wrapper labels Mar 31, 2022
@koppor

koppor commented Mar 31, 2022

Copy link
Copy Markdown
Member

News of Java 18: https://www.infoworld.com/article/3630510/jdk-18-the-new-features-in-java-18.html - especially UTF-8 as default - yeah 🎉

@koppor

koppor commented Mar 31, 2022

Copy link
Copy Markdown
Member

IntelliJ doesn't seem to support Java 18 (yet): https://www.jetbrains.com/help/idea/supported-java-versions.html#2021 - maybe, we should wait until there is an IntelliJ update?

@calixtus

calixtus commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

I agree. There is no hurry.

@Siedlerchr Siedlerchr added this to the v6.0 milestone Apr 3, 2022
@koppor

koppor commented Apr 25, 2022

Copy link
Copy Markdown
Member

https://whichjdk.com/ --> UTF-8 as default

grafik

Nevertheless, as soon as Eclipse supports JDK18, we should update

@ThiloteE ThiloteE mentioned this pull request May 4, 2022
Closed
2 tasks
@koppor

koppor commented May 9, 2022

Copy link
Copy Markdown
Member

Fetcher tests failing is mostly IEEE:

java.io.IOException: Server returned HTTP response code: 503 for URL: https://ieeexplore.ieee.org/document/7421926/

@Siedlerchr Siedlerchr merged commit 177d5ec into main May 9, 2022
@Siedlerchr Siedlerchr deleted the jdk18 branch May 9, 2022 20:54
@calixtus calixtus removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dev: build-system gradle-wrapper Pull requests that update Gradle wrapper

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@calixtus @koppor @Siedlerchr