Skip to content

Fix search bar icons in linux#8023

Merged
Siedlerchr merged 3 commits into
mainfrom
fix-ikonli-search-buttons
Aug 23, 2021
Merged

Fix search bar icons in linux#8023
Siedlerchr merged 3 commits into
mainfrom
fix-ikonli-search-buttons

Conversation

@calixtus

@calixtus calixtus commented Aug 23, 2021

Copy link
Copy Markdown
Member

Fixed search bar icons after change to ikonli were in Linux only drawn in one color, unselected as well as selected.
Fixes #8014

Before:
grafik

After:
grafik

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@calixtus calixtus changed the title Fix search bar icons Fix search bar icons in linux Aug 23, 2021
@calixtus calixtus added platform: linux status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Aug 23, 2021
@Siedlerchr

Copy link
Copy Markdown
Member

Changelog would have been not necessary I guess

@Siedlerchr Siedlerchr merged commit cef4151 into main Aug 23, 2021
@Siedlerchr Siedlerchr deleted the fix-ikonli-search-buttons branch August 23, 2021 22:40
@wujastyk

Copy link
Copy Markdown

JabRef 5.4--2021-08-30--ff65eb8
Linux 5.4.0-81-generic amd64
Java 16.0.2
JavaFX 16+8

Yes, search button behaviour is now as expected.

I cannot generate a freeze any more. Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: linux status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search: no visual clue about selected options

4 participants