Oobranch e : add backend#7790
Merged
Merged
Conversation
JabRef#7788 (review) - more use of StringUtil.isNullOrEmpty - private final XTextRangeCompare cmp; - List<V> partition = partitions.computeIfAbsent(partitionKey, _key -> new ArrayList<>()); - visualSort does not throw WrappedTargetException, NoDocumentException - set renamed to comparableMarks
In Backend52:
- use a single expression
- expand comment
- rename refMarkName to markName
Collectors.joining(",") moved to Codec52.getUniqueMarkName
Member
|
Looks good to me! Thanks. After a second review we can merge. |
calixtus
approved these changes
Aug 21, 2021
Siedlerchr
reviewed
Aug 21, 2021
| } | ||
|
|
||
| List<String> keys = Arrays.asList(citeMatcher.group(3).split(",")); | ||
| String i = citeMatcher.group(1); |
Member
There was a problem hiding this comment.
i is normally used only in loops, but for the moment it doesn't matter. You can fix this in a later PR.
Siedlerchr
approved these changes
Aug 21, 2021
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Just some minor nitpicking things, but nothing important. So I merge ths now.
A general hint: Please use more descriptive variable names where possibe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds backend: manages ranges and data storage for citation groups.
Provides cursor to write citation markers to.