Skip to content

Add an icon picker in group edit dialog for issue#6142#7758

Closed
EricLee543 wants to merge 6 commits into
JabRef:mainfrom
EricLee543:create_icon_dialog
Closed

Add an icon picker in group edit dialog for issue#6142#7758
EricLee543 wants to merge 6 commits into
JabRef:mainfrom
EricLee543:create_icon_dialog

Conversation

@EricLee543

@EricLee543 EricLee543 commented May 20, 2021 •
edited
Loading

Copy link
Copy Markdown

For issue #6142 , I add an icon picker in group edit dialog.
There are two ways to select an icon. First, select an icon by icon picker button. Second, input icon name in iconfield. This dialog is implemented by ScrollPane and Pagination. Here is a demo video.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.
IconPIckerVideo.1.mov

@EricLee543 EricLee543 changed the title Create icon dialog Add an icon picker in group edit dialog for issue#6142 May 20, 2021
@calixtus

calixtus commented May 23, 2021

Copy link
Copy Markdown
Member

Hi @EricLee543 on first sight, this looks like a really cool idea, I did not yet look into the code though.
One idea to improve the UI in the group dialog: Maybe it is possible to unify the button icon picker and the text field into something combobox-like field and add a graphic node to the text displaying the selected icon in the text field.
Thanks for your work!

@Siedlerchr

Siedlerchr commented May 24, 2021

Copy link
Copy Markdown
Member

Please have a look at the checkstyle/reviewdog stuff

@Siedlerchr Siedlerchr added the status: changes-required Pull requests that are not yet complete label May 24, 2021
@calixtus calixtus mentioned this pull request Jun 3, 2021
Merged
5 tasks
@koppor

koppor commented Jun 3, 2021

Copy link
Copy Markdown
Member

@ericlee Welcome to JabRef development.

The first thing to learn about open-source-projects is that developers have limited time resources. They rely on automatation.

Did you see our automated tools?

grafik

Following is accessible via: https://github.com/JabRef/jabref/pull/7758/files

grafik

Is this part of a university course? If yes, based on our long experiences, I see the following things: Your supervisor seem not to have contacted us in advanced (see https://devdocs.jabref.org/teaching for details). Thus, I have to ask you whether you intend to work on this PR for the next weeks?

@EricLee543 EricLee543 closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: changes-required Pull requests that are not yet complete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EricLee543 @calixtus @Siedlerchr @koppor