Skip to content

use java 16 as build environment for deployment#7704

Merged
koppor merged 3 commits into
mainfrom
java16
May 5, 2021
Merged

use java 16 as build environment for deployment#7704
koppor merged 3 commits into
mainfrom
java16

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented May 5, 2021 •
edited by koppor
Loading

Copy link
Copy Markdown
Member
  • Test build dmg + pkg under mac
  • Test exe and portable under windows
  • Test linux packages + portables
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@k3KAW8Pnf7mkmdSMPHz27

k3KAW8Pnf7mkmdSMPHz27 commented May 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

I have only tried installing and then opening JabRef. Is there something else I should test?

Intel, Mac OS X 10.15.7

  • pkg and dmg, installing to /Applications/, and the portable version works
  • I only checked the certificate for the .pkg (which were fine) but I didn't get any unexpected popup so 👍

(From the .dmg)

JabRef 5.3-PullRequest7704.308--2021-05-05--584b44f
Mac OS X 10.15.7 x86_64 
Java 16.0.1 
JavaFX 16+8

Windows 10 Pro, DEP on, but not the latest feature pack

  1. .msi says that the publisher could not be verified (which I guess is normal?), but installs and opens
  2. Portable said "Your administrator requires a security scan of this item." but then opened without any issue

@koppor koppor changed the title use java 16 as build environemnt for deployment use java 16 as build environment for deployment May 5, 2021
@koppor

koppor commented May 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Works in WSL2.

grafik

Side note: I ran into https://askubuntu.com/a/406015/196423. Solution

sudo mkdir /usr/share/desktop-directories/

@koppor koppor merged commit a3f093d into main May 5, 2021
@koppor koppor deleted the java16 branch May 5, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Siedlerchr @k3KAW8Pnf7mkmdSMPHz27 @koppor