Added DoiDuplicationCheckerTest to increase coverage#7698
Merged
Conversation
koppor
requested changes
May 3, 2021
koppor
left a comment
Member
There was a problem hiding this comment.
In general: Looks good to me.
Some code nitpick: variable naming
Siedlerchr
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contributes to issue #6207, which is to add more unit tests or improve existing ones. I used Pitest to compute the line and mutation coverage. Since DoiDuplicationChecker did not have its unit test (its method was being tested in other test classes), I added the test to increase both coverages.
Before:

After:

CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)