Fixes #7016 toggle of special fields does not work for sorted entries#7656
Merged
Conversation
Make a copy of selected entries and change field in the copy so that the sort strategy will not influence the result.
k3KAW8Pnf7mkmdSMPHz27
approved these changes
Apr 25, 2021
k3KAW8Pnf7mkmdSMPHz27
left a comment
Member
There was a problem hiding this comment.
This looks good to me.
I think there used to be a different open issue related to the list update on permutation in
jabref/src/main/java/org/jabref/gui/LibraryTab.java
Lines 475 to 476 in 4bf895b
Perhaps that one is also solved by this PR or a similar strategy. I'll see if I can find it 😃
| - We fixed an issue with saving large `.bib` files [#7265](https://github.com/JabRef/jabref/issues/7265) | ||
| - We fixed an issue with very large page numbers [#7590](https://github.com/JabRef/jabref/issues/7590) | ||
| - We fixed an issue where the article title with curly brackets fails to download the arXiv link (pdf file). [#7633](https://github.com/JabRef/jabref/issues/7633) | ||
| - We fixed an issue with toggle of special fields does not work for sorted entries [#7016](https://github.com/JabRef/jabref/issues/7016) |
There was a problem hiding this comment.
I'd suggest 'We fixed an issue with toggling special fields for sorted entries.'
Siedlerchr
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7016
Make a copy of selected entries and change field in the copy so that the sort strategy will not influence the result.
The original version used for-each on the selected entry list but ConcurrentModificationException happened. Then I tried to replace it with normal for loop but the toggle problem still exist, though the exception did not occur any more. By checking the list in each loop I found that the order of the items in this list was changed during the for loop. Not exactly knowing how the sorting strategy is performed, I make a copy of the list and do field change on the copied list. Finally the toggle action performs correctly.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)