Add simple unit tests#7545
Merged
Merged
Conversation
1. Increase branch coverage by 25% 2. Add test to cover more branches
1. Increase branch coverage to 100%
1. Check for every ASCII character 2. Check two off points for the boundaries (outside of ASCII codes)
1. Added more test input partitions
1. Added boundary tests
Add line between import statements
Duplicate changes in another pull request
Siedlerchr
approved these changes
Mar 16, 2021
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks, that looks good to me, cool that you used a parameterized Test!
calixtus
approved these changes
Mar 17, 2021
calixtus
left a comment
Member
There was a problem hiding this comment.
Indeed, looks good. Thanks! Merging now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added some simple unit tests that will increase code coverage / branch coverage.
They contribute to issue #6207
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)