Skip to content

Update to javafx 16#7512

Merged
Siedlerchr merged 1 commit into
masterfrom
openjfx16
Mar 11, 2021
Merged

Update to javafx 16#7512
Siedlerchr merged 1 commit into
masterfrom
openjfx16

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Mar 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

https://github.com/openjdk/jfx/blob/master/doc-files/release-notes-16.md

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 10, 2021
@tobiasdiez

tobiasdiez commented Mar 10, 2021

Copy link
Copy Markdown
Member

Cool! It is working without a problem locally?

Could you please also revert #5497 since the javafx bug is now fixed. According to #5226 that's the only issue that was waiting on a javafx update.

@Siedlerchr

Siedlerchr commented Mar 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Reverting #5497 would create a merge conflict with #7336
Worked fine locally

@Siedlerchr Siedlerchr merged commit 2c784e6 into master Mar 11, 2021
@Siedlerchr Siedlerchr deleted the openjfx16 branch March 11, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Siedlerchr @tobiasdiez