Fixed columns shrink in width when enlarging the JabRef window#7507
Conversation
tobiasdiez
left a comment
There was a problem hiding this comment.
Very nice that you found this mistake. It was hunting us for a very long time now.
There is a proposal to completely rewrite the resize policy in #7181. But since this still needs some work until this is finished, I propose to merge this PR nonetheless. Maybe this makes #7181 actually obsolete - I'll let @koppor and @DominikVoigt decide this.
|
@tobiasdiez Thanks for your acknowledgment |
|
@tobiasdiez No, it does not make it obsolete. Even though, I am for +1 for this quick fix. |
There was a problem hiding this comment.
Thanks for this fix. It should work with the current implementation of the SmartConstrainedResizePolicy and I'm going to merge it (after two approvals).
However, it's no substitute for the long term solution @koppor and @DominikVoigt proposed, because this PR still depends on reflection. So please don't be too sad, if sooner or later this SmartConstrainedResizePolicy will be removed.
In method 'resize', in order to make sure that we are staying under the total table width, the program used to reduce the newSize by two for every column. Cause the method will be call for many times, that will occur the problem which shown in the video in issue 6818. I do a little bit modify for this implement of controlling width, which is reduce the width only if the current width exceed the total width and only reduce for the surplus part.
Fixes #6818
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)Before:
before.mp4
After:
after.mp4