Fixed validation before typing in new entry dialog #7020#7471
Merged
Conversation
Member
|
For me this doesn't make any change, because you still have the init of the visualizer in line 178 (at the bottom of initialize) |
Contributor
Author
|
@Siedlerchr FIxed |
calixtus
reviewed
Mar 1, 2021
Comment on lines
+82
to
+85
| ControlHelper.setAction(generateButton, this.getDialogPane(), event -> { | ||
| viewModel.runFetcherWorker(); | ||
| visualizer.initVisualization(viewModel.idFieldValidationStatus(), idTextField, true); | ||
| }); |
Member
There was a problem hiding this comment.
Sorry, but this does not seem to work, since the generate button is disabled by default and the validation does only check if the button isNotBlank.
calixtus
approved these changes
Mar 4, 2021
calixtus
left a comment
Member
There was a problem hiding this comment.
Looks good to me now. Thanks!
Siedlerchr
approved these changes
Mar 4, 2021
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not show an error message if there is no error
Fixes #7020