Skip to content

Fix drag and drop of bib files #7470

Merged
calixtus merged 2 commits into
masterfrom
fixDragAndDropLibrary
Feb 27, 2021
Merged

Fix drag and drop of bib files #7470
calixtus merged 2 commits into
masterfrom
fixDragAndDropLibrary

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Feb 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #7464

When loading/opening a bib file a new "normal" Tab is inserted to indicate loading. That is later removed again and it's not an instanceof our LibraryTab

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 26, 2021
tobiasdiez
tobiasdiez approved these changes Feb 26, 2021
View reviewed changes

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@calixtus

calixtus commented Feb 27, 2021

Copy link
Copy Markdown
Member

Looks good. Just wondering how there is a case we have a tab that isn't a LibraryTab...

@calixtus calixtus merged commit c7f2671 into master Feb 27, 2021
@calixtus calixtus deleted the fixDragAndDropLibrary branch February 27, 2021 06:47
@Siedlerchr

Siedlerchr commented Feb 27, 2021

Copy link
Copy Markdown
Member Author

@calixtus when you drag and drop a bib file, first a normal temporary tab is inserted with the title Opening...
This one is afterwards removed and replaced with the library tab

This was referenced Jan 18, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drag-and-drop of a bib file generate a loop of exceptions

3 participants

@Siedlerchr @calixtus @tobiasdiez