Use env to determine python3 location#7447
Conversation
In general, it is recommended to use `#!/usr/bin/env python3` as the shebang instead of the hardcoded `!#/usr/bin/python3`. See <https://stackoverflow.com/a/5709632> for more information.
tobiasdiez
left a comment
There was a problem hiding this comment.
Thanks, that's a nice improvement indeed. Could you please also change the mac version of the script https://github.com/JabRef/jabref/blob/master/buildres/mac/jabrefHost.py and add a short entry to the changelog.
@tobiasdiez Done! Listed the change under Changed, hope thats fine :) |
|
I thought we had changed this already. Great change. |
|
I see, I was only able to test it on my mac with Python installed via brew. |
|
I tried but there were too many error reports. |
|
So on mac we still should use !#/usr/bin/python3 ? |
|
The issue was looked at here: JabRef/JabRef-Browser-Extension#177 |
|
I just confirmed on a brand new Mac. |
Using `/usr/bin/env python3` instead of `/usr/bin/python3` would require the XCode command line developer tools. This is not feasible.
|
Thanks, and sorry for the misleading suggestion from my side. |
In general, it is recommended to use
#!/usr/bin/env python3as the shebang instead of the hardcoded!#/usr/bin/python3.See https://stackoverflow.com/a/5709632 for more information.
Related to JabRef-Browser-Extension #177, especially this comment.