Switch to Ikonli#7424
Conversation
Needs some more changes
|
Parsing of Group icons works also fine and we can now use all of MateralDesignIcons2 |
|
Besides the checkstyle issues, looks good to me. |
remove fontawesomefx update checker rule from gradle
|
Gui Test is still failing, need to check that |
tobiasdiez
left a comment
There was a problem hiding this comment.
That looks very nice! Thanks!
A few minor comments from my side
| private static InputStream getMaterialDesignIconsStream() { | ||
| return IconTheme.class.getResourceAsStream("/fonts/materialdesignicons-webfont.ttf"); | ||
| public static Optional<JabRefIcon> findIcon(String code, Color color) { | ||
| return ICON_NAMES.stream().filter(icon -> icon.toString().equals(code.toUpperCase(Locale.ENGLISH))) |
There was a problem hiding this comment.
Maybe make ICON_NAMES a hashmap? Looking up the icon via the filter can otherwise become quite expensive.
There was a problem hiding this comment.
And maybe initalize ICON_NAMES lazily, i.e. only when findIcon is called.
| public JabRefIconView(IconTheme.JabRefIcons icon) { | ||
| this(icon, "1em"); | ||
|
|
||
| super(icon.getIkon()); |
There was a problem hiding this comment.
Refactor to this(icon, calculateDefaultSize()) ?
There was a problem hiding this comment.
Doesn't work because I need getFont from the super class.
* upstream/master: Bump unirest-java from 3.11.10 to 3.11.11 (#7428) Bump libreoffice from 7.0.4 to 7.1.0 (#7431) Bump unoloader from 7.0.4 to 7.1.0 (#7432) Bump byte-buddy-parent from 1.10.19 to 1.10.20 (#7434) Bump junit-platform-launcher from 1.7.0 to 1.7.1 (#7435) Bump junit-jupiter from 5.7.0 to 5.7.1 (#7436) Bump gittools/actions from v0.9.8 to v0.9.9 (#7433) Bump junit-vintage-engine from 5.7.0 to 5.7.1 (#7429) Bump lucene-queryparser from 8.7.0 to 8.8.0 (#7430)
try fix gui test
|
I have no clue why the GUI test fails, somehow it can't find the icon from our ikon provider |
|
The GUI Test works in general (test in Eclipse), but no clue how to modify the module-info.test to get it work. |
* upstream/master: Fix typos (#7425)
|
Status: Tests failing because gradle is missing some testing plugins. |
* upstream/master: Bump pascalgn/automerge-action from v0.13.0 to v0.13.1 (#7445) Auto-approve depend-a-bot-PRs (#7332) Clarify that changelog is user-facing Remove unmaintained AUTHORS file Fixes the issue "Non valid number as font size results in an uncaught exception." (#7438) Zbmath fetcher (#7440) Bump me.champeau.gradle.jmh from 0.5.2 to 0.5.3 (#7444) Bump styfle/cancel-workflow-action from 0.7.0 to 0.8.0 (#7446)
Fixes #7058
Group with
quadcoptericonRemaining Issue: