Fix wrong conversion of unicode chars#7419
Merged
Siedlerchr merged 5 commits intoFeb 3, 2021
Merged
Conversation
tobiasdiez
requested changes
Feb 3, 2021
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks a lot! Can you please also add a test that verifies that everything is working now.
| {"119978", "Oscr", "$\\mathcal{O}$"}, // script capital O -- possibly use \mathscr | ||
| {"119984", "Uscr", "$\\mathcal{U}$"} // script capital U -- possibly use \mathscr | ||
| {"119984", "Uscr", "$\\mathcal{U}$"}, // script capital U -- possibly use \mathscr | ||
| {"120598", "", "$\\epsilon}$"} // mathematical italic epsilon U+1D716 -- requires amsmath |
Member
There was a problem hiding this comment.
I think the closing } is too much here.
Siedlerchr
approved these changes
Feb 3, 2021
Member
|
Thanks for analyzing the issue and your fix! LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7387
Fixed the wrong conversion of unicode characters with a codepoint higher than the max value of the primitive type char in the unicode to latex formatter.