Improved detection of long DOI's within text. fixes #7256.#7257
Closed
PremKolar wants to merge 1 commit into
Closed
Improved detection of long DOI's within text. fixes #7256.#7257PremKolar wants to merge 1 commit into
PremKolar wants to merge 1 commit into
Conversation
Member
|
Please fix the checkstyle issue, then it's good from my side! |
5 tasks
Member
|
@DominikVoigt was so kind to just fix the checkstyle issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7256
Extraction of long DOI's from within text no longer trips over DOI's placed at the end of sentences or before commata.
E.g.
"Breast Cancer Res Treat. 2018 July ; 170(1): 77–87. doi:10.1007/s10549-018-4743-9. bla blubb"
is now processed successfully as 10.1007/s10549-018-4743-9 without the trailing period.