Skip to content

[WIP] Try with jaxb 3.0 and xjc#7161

Closed
Siedlerchr wants to merge 7 commits into
masterfrom
udpatejaxb
Closed

[WIP] Try with jaxb 3.0 and xjc#7161
Siedlerchr wants to merge 7 commits into
masterfrom
udpatejaxb

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Dec 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #7137

Finally I was able to fix this jaxb jakarta dependeny update. Hellish complicated with all those implementaitons and version numbers and different namespaces ☺️

TODO:

  • Depends on xmpbox/pdfbox
  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr mentioned this pull request Dec 4, 2020
Closed
@Siedlerchr Siedlerchr requested a review from tobiasdiez December 4, 2020 19:07
@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Dec 4, 2020
@Siedlerchr

Siedlerchr commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

Hm:

Error: Two versions of module jakarta.activation found in /Users/runner/work///build/jlinkbase/jlinkjars (jakarta.activation-api-2.0.0.jar and jakarta.activation-2.0.0.jar)

@Siedlerchr

Siedlerchr commented Dec 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

The failing xmp test seems to come from:

java.lang.ClassNotFoundException: javax.xml.bind.DatatypeConverter
Seems to be a problem with pdfbox not yet beeing jakarta compatible argh!

@Siedlerchr

Siedlerchr commented Dec 5, 2020

Copy link
Copy Markdown
Member Author

The problem is https://github.com/apache/pdfbox/blob/5f6c8b4e1fd32396889206f2222dce26480d2a95/xmpbox/src/main/java/org/apache/xmpbox/DateConverter.java

xmpbox/pdfbox still depends on javax.xml.bind that is obviously no longer present.

@Siedlerchr Siedlerchr added the status: freeze Issues posponed to a (much) later future label Dec 6, 2020
@Siedlerchr Siedlerchr mentioned this pull request Dec 6, 2020
Open
33 tasks
@tobiasdiez tobiasdiez closed this Dec 6, 2020
@tobiasdiez tobiasdiez deleted the udpatejaxb branch December 6, 2020 20:54
@Siedlerchr Siedlerchr mentioned this pull request Dec 7, 2020
Closed
@tobiasdiez

tobiasdiez commented Dec 21, 2020

Copy link
Copy Markdown
Member

@Siedlerchr have you reported the issues upstream with xmpbox?

@Siedlerchr

Siedlerchr commented Dec 21, 2020

Copy link
Copy Markdown
Member Author

@koppor wanted to do this because he already has an account at the apache

@koppor

koppor commented Dec 28, 2020

Copy link
Copy Markdown
Member

Issue submitted: https://issues.apache.org/jira/browse/PDFBOX-5061

Pull request fixing the issue submitted: apache/pdfbox#101

@tobiasdiez tobiasdiez mentioned this pull request Apr 12, 2021
Closed
@Siedlerchr Siedlerchr self-assigned this May 3, 2021
@Siedlerchr

Siedlerchr commented May 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

XMP is now working with pdfbox 3.0.0.
Current problem: application insights 2.x contain dependency to xml.bind. Seems to be removed in newer version but that is not yet? No idea

@tobiasdiez

tobiasdiez commented May 4, 2021

Copy link
Copy Markdown
Member

Application insights uses a fat jar that contains all dependencies microsoft/ApplicationInsights-Java#1060, so this shouldn't actually be a problem.

@Siedlerchr

Siedlerchr commented May 4, 2021

Copy link
Copy Markdown
Member Author

Well, the original error was.

aused by: java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException
        at com.microsoft.applicationinsights.internal.config.TelemetryConfigurationFactory.<init>(TelemetryConfigurationFactory.java:90) ~[applicationinsights-core-2.4.1.jar:?]
        at com.microsoft.applicationinsights.internal.config.TelemetryConfigurationFactory.<clinit>(TelemetryConfigurationFactory.java:66) ~[applicationinsights-core-2.4.1.jar:?]
        at com.microsoft.applicationinsights.TelemetryConfiguration.getActive(TelemetryConfiguration.java:70) ~[applicationinsights-core-2.4.1.jar:?]
    at org.jabref.gui.Globals.startTelemetryClient(Globals.java:122) ~[JabRef-100.0.0.jar:?]

With version 3.x they also changed the approach. Apparently they now use an java agent. Not exactly sure.
https://docs.microsoft.com/de-de/azure/azure-monitor/app/java-get-started?tabs=maven

@koppor koppor mentioned this pull request Feb 24, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasdiez tobiasdiez Awaiting requested review from tobiasdiez

Assignees

@Siedlerchr Siedlerchr

Labels

status: freeze Issues posponed to a (much) later future

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Siedlerchr @tobiasdiez @koppor