Skip to content

Fix downloaded files moved to citation key dir#6608

Merged
Siedlerchr merged 6 commits into
masterfrom
fixFileLinkDL
Jun 15, 2020
Merged

Fix downloaded files moved to citation key dir#6608
Siedlerchr merged 6 commits into
masterfrom
fixFileLinkDL

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Jun 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #6589

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 13, 2020
@Siedlerchr Siedlerchr requested a review from tobiasdiez June 13, 2020 16:14
@Siedlerchr Siedlerchr changed the title Fix dowmloaded files moved to citaiton key dir Fix downloaded files moved to citation key dir Jun 13, 2020
systemoperator
systemoperator reviewed Jun 14, 2020
View reviewed changes
Comment thread src/test/java/org/jabref/logic/cleanup/MoveFilesCleanupTest.java Outdated
koppor
koppor requested changes Jun 14, 2020
View reviewed changes

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick 😇

Comment thread src/test/java/org/jabref/logic/util/io/FileUtilTest.java Outdated
Comment thread src/main/java/org/jabref/logic/util/io/FileUtil.java
@Siedlerchr
Update FileUtilTest.java
fff66d2 
Remove obsolete comment
@Siedlerchr
Update FileUtilTest.java
f17cb5d 
Revert previous change., remove right comment
@Siedlerchr Siedlerchr merged commit ed96faa into master Jun 15, 2020
@Siedlerchr Siedlerchr deleted the fixFileLinkDL branch June 15, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

+1 more reviewer

@systemoperator systemoperator systemoperator left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Download of files put them in subfolders

4 participants

@Siedlerchr @koppor @systemoperator @tobiasdiez