Skip to content

Add some javadoc and fix the preview update issue#6516

Merged
Siedlerchr merged 1 commit into
JabRef:masterfrom
leitianjian:entry-preview-content-update
May 25, 2020
Merged

Add some javadoc and fix the preview update issue#6516
Siedlerchr merged 1 commit into
JabRef:masterfrom
leitianjian:entry-preview-content-update

Conversation

@leitianjian

@leitianjian leitianjian commented May 24, 2020

Copy link
Copy Markdown
Contributor

Fixes #6447

I have taken a long time considering how to update the preview when preference change. After I found that the PreviewPanel will be bind to entry in FieldsEditorTab.java, then we can just update the layout in PreviewPanel.java#setEntry()

Some ideas:
Can we using observer pattern to refactor the code: JabRefPreferences as Observable object and component need preferences can register as Observer. If the preferences were changed, we can notify the affected component to do an update?

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@leitianjian leitianjian marked this pull request as ready for review May 24, 2020 12:47
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 24, 2020
@Siedlerchr

Siedlerchr commented May 24, 2020

Copy link
Copy Markdown
Member

Thanks, codewise looks good to me. We are currently in the process of refactoring the preferences in general and trying to solve the "updating of preferences" without restarting JabRef as well.

@leitianjian

leitianjian commented May 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks, codewise looks good to me. We are currently in the process of refactoring the preferences in general and trying to solve the "updating of preferences" without restarting JabRef as well.

What is the current idea of refactoring these preferences code? I wonder where I can see these discussions? Thanks!

@calixtus

calixtus commented May 25, 2020

Copy link
Copy Markdown
Member

@leitianjian : developer discussion happens here: https://gitter.im/JabRef/jabref .
Feel free to participate or even contribute. If you like, we can talk a bit about the principles behind my current attempt in refactoring the preferences.

@leitianjian

leitianjian commented May 25, 2020

Copy link
Copy Markdown
Contributor Author

@leitianjian : developer discussion happens here: https://gitter.im/JabRef/jabref .
Feel free to participate or even contribute. If you like, we can talk a bit about the principles behind my current attempt in refactoring the preferences.

Thanks for your kindness. Recently I'm busy with other things. So, I cannot fully participate in it, but, I will keep track of your pr and the chat in gitter. Maybe I can learn something or provide some ideas

@Siedlerchr Siedlerchr merged commit 86b04a7 into JabRef:master May 25, 2020
@Siedlerchr

Siedlerchr commented May 25, 2020

Copy link
Copy Markdown
Member

Thanks again for your contribution! I took the freedom to merge it ;)

@leitianjian

leitianjian commented May 26, 2020

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changes in entry preview are not saved

3 participants

@leitianjian @Siedlerchr @calixtus