Update citeproc-java to 2.1.0-SNAPSHOT and enable experimental pure-Java mode#5997
Closed
michel-kraemer wants to merge 1 commit into
Closed
Update citeproc-java to 2.1.0-SNAPSHOT and enable experimental pure-Java mode#5997michel-kraemer wants to merge 1 commit into
michel-kraemer wants to merge 1 commit into
Conversation
koppor
reviewed
Feb 22, 2020
koppor
left a comment
Member
There was a problem hiding this comment.
Thank you for the action taken. We need to test it.
| // lang and forceLang are set to the default values of other CSL constructors | ||
| cslInstance = new CSL(dataProvider, new JabRefLocaleProvider(), newStyle, "en-US", false); | ||
| cslInstance = new CSL(dataProvider, new JabRefLocaleProvider(), | ||
| new DefaultAbbreviationProvider(), null, newStyle, "en-US", false, true); |
Member
There was a problem hiding this comment.
Nitpick: Does CSL also provide a builder pattern (see https://github.com/HugoMatilla/Effective-JAVA-Summary#2-use-builders-when-faced-with-many-constructors). Passing "null" and "false" and "true" is wired ^^.
Contributor
Author
There was a problem hiding this comment.
Good catch! Actually, almost all classes from citeproc-java provide a Builder except for the most important one 😂I'll add this in the next version.
Member
|
Superseeded by #6010 |
Member
|
Due to packaging for Debian, I would like to see things going here. |
Member
|
We updated the lib in #6010 |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #5622, this pull request updates citeproc-java to version 2.1.0-SNAPSHOT and enables the new experimental pure-Java mode. The entry previews are super fast now and seem to work well.