Switch to git subtree#5647
Merged
Merged
Conversation
git-subtree-dir: src/main/resources/csl-styles git-subtree-split: f71cd32
…resources/csl-styles'
…e358 git-subtree-dir: src/main/resources/csl-locales git-subtree-split: 9785a6e3584e8c903df3d5a53f0e800dcabd282b
…resources/csl-locales'
0decfbe to
641f041
Compare
Member
|
I would suggest you create an ADR as well for this decision and please update the getting started guides on cloning and fetching |
tobiasdiez
approved these changes
Nov 20, 2019
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
LGTM. A follow-up would be to write a small python script that creates and updates an index file for the citation styles (and then also include this in the update workflow)
This was referenced Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have issues with git submodules. Since we "just" need to have the code in our repostiory, git submoulde seems to be the better choice.
This PR switches from sub modules to sub trees. Including an update twice a month. Maybe, I need to play around with push-rights to the
masterbranch. Will do that later to keep things moving.Sorry for 6408457. This should not be in here, but it's difficult to remove it with
git rebase -i.More background information: