Let codecov fail during a test#5618
Conversation
| - TEST_SUITE=databaseTest | ||
| - TEST_SUITE=guiTest | ||
| # codecov may fail by itself (see gradle build file) | ||
| # The codecov test itself fails only in case there is an issue with the codecov update. Thus, failing codecov is allowed |
There was a problem hiding this comment.
A 'not' is missing here, right?
15e098f to
3e81a2f
Compare
|
Travis now sometimes fails with following output (at codecov) |
|
This PR reverted parts of #5609, because of #5609 (comment) |
|
CodeCov should really fail if test coverage decreases. This fosters awareness to add tests. CodeCov should not fail because of timeouts during tests. At least not if that happens often (as it is currently the case) I assume the timeout is because some databases started and stopped in parallel and maybe that eats too much cpu, ram, ... |
|
Also fails here: https://travis-ci.org/JabRef/jabref/builds/615330243?utm_source=github_status&utm_medium=notification Flagged as devcall with the hope, we have time to talk about it today. |
|
Decision: We keep as is and force ourselves to fix the DBMS tests. - Maybe move to GitHub actions for that, too. |
|
Issue tracking this: #5602 |
CoveCov test are allowed to fail (see gradle build file) but the build should fail if there is a problem with the code cov update.