Skip to content

Fix destination for jabref mozilla json#5503

Merged
tobiasdiez merged 2 commits into
masterfrom
debRpmInstall
Oct 27, 2019
Merged

Fix destination for jabref mozilla json#5503
tobiasdiez merged 2 commits into
masterfrom
debRpmInstall

Conversation

@LyzardKing

Copy link
Copy Markdown
Collaborator

Fixes #5502
I'd keep the branch open, to enable test builds of deb/rpm packages while we fix the last jpackage options.

@Siedlerchr

Copy link
Copy Markdown
Member

Ah shit, oss.sonatype maven repo once again is down...

@LyzardKing

Copy link
Copy Markdown
Collaborator Author

It managed to build locally and went down just as I pushed the change upstream...

@LyzardKing

Copy link
Copy Markdown
Collaborator Author

@Siedlerchr I forced the build to run again, since the repo is up now.
Once it's built let me know if you can test it!

@koppor

koppor commented Oct 27, 2019

Copy link
Copy Markdown
Member

@LyzardKing What testing do you mean? None of us has Linux machines :(

If you say, it's good to go, we can merge!

@LyzardKing

Copy link
Copy Markdown
Collaborator Author

It should be fine.
Just to be on the safe side I'll try rebasing on master so I can test the deb first

@koppor

koppor commented Oct 27, 2019

Copy link
Copy Markdown
Member

Seeing #5502, @Siedlerchr is our linux tester. 🎉

@Siedlerchr

Copy link
Copy Markdown
Member

Seeing #5502, @Siedlerchr is our linux tester. 🎉

You wish. Nope, I have only a slow Ubuntu VM (running on my hdd cause my ssd is too small) for testing stuff.

@LyzardKing

Copy link
Copy Markdown
Collaborator Author

Seeing #5502, @Siedlerchr is our linux tester. tada

You wish. Nope, I have only a slow Ubuntu VM (running on my hdd cause my ssd is too small) for testing stuff.

😄

I tested on a live image with no jabref version, with the version in the ubuntu repo and reinstalling the deb.
The install seems to never fail and copies the proper json file.
@Siedlerchr if you want to test it to be sure, then you're free to merge

@tobiasdiez tobiasdiez merged commit fa25ee9 into master Oct 27, 2019
@tobiasdiez tobiasdiez deleted the debRpmInstall branch October 27, 2019 21:33
@LyzardKing

LyzardKing commented Oct 27, 2019

Copy link
Copy Markdown
Collaborator Author

That was fast..
@tobiasdiez I would have kept the branch, to test the deb, since the licence/copyright stuff is still missing.. But we can open a new one once we figure it out
Regarding that, I have never had a reply on the mailing list..

@tobiasdiez

Copy link
Copy Markdown
Member

Yeah, you are not alone. I've also send a few mails to the jdk mailing list and didn't get a single response yet.
The license stuff is not super important so I guess it is fine to wait until jpackage is released and properly documented.

(the branches are deleted automatically btw)

@LyzardKing

LyzardKing commented Oct 27, 2019

Copy link
Copy Markdown
Collaborator Author

Ah ok.. sorry
The rest of the deb should work..and the license in the rpm should (in theory) work
since it's set in a separate command..
But I'll test that tomorrow in a vm ;)

@Siedlerchr

Copy link
Copy Markdown
Member

Works fine now.

@LyzardKing

Copy link
Copy Markdown
Collaborator Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error installing jabref deb package in ubuntu: native messaging host is not a dir

4 participants