Fix postrm in deb#5455
Merged
Merged
Conversation
Manually set license/copyright for deb (rpm in gradle)
tobiasdiez
approved these changes
Oct 17, 2019
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks. Could you please report these problem also to the jpackage devs.
Collaborator
Author
|
The postrm error was my fault, the copyright issue is reported upstream regarding the fact that it doesn't copy to the DEBIAN folder, I'll follow up with another email asking about the format of the license file, but I haven't heard back yet. |
Member
|
@LyzardKing Just a reminder, you can directly create branches at the jabref upstream repo. You have push rights. So no need to work in your fork ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error in the postrm file could prevent reinstalls
Remove the associations file and set in .desktop
(Avoid having another extra file for a single line declaration)
Manually set license/copyright for deb (rpm in gradle):
(The parsing of the license.md file is not working consistently)