Fix NPE when opening a non existing file from the recent files menu#5338
Merged
Conversation
dialogService object was null, because the FileHistoryMenu class is initialized before the ctor of JabRef frame creates the dialog service object
tobiasdiez
requested changes
Sep 21, 2019
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
What about moving the initialization
to the constructorJabRefFrame (and in addition making the dialogservice an constructor argument of filehistorymenu)?
tobiasdiez
approved these changes
Sep 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5334
dialogService object was null, because the FileHistoryMenu class is initialized before the ctor of JabRef frame creates the dialog service object