Skip to content

Remove module exports for JabRef#5324

Merged
Siedlerchr merged 1 commit into
masterfrom
moduleExport
Sep 16, 2019
Merged

Remove module exports for JabRef#5324
Siedlerchr merged 1 commit into
masterfrom
moduleExport

Conversation

@tobiasdiez

@tobiasdiez tobiasdiez commented Sep 16, 2019

Copy link
Copy Markdown
Member

As we are not providing a JabRef library, we don't need to export anything. This should also resolve all these warnings shown in the IDE.

@calixtus This one is for you ;-).

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 16, 2019
@calixtus

calixtus commented Sep 16, 2019

Copy link
Copy Markdown
Member

You're killing me. 🤣

@Siedlerchr

Siedlerchr commented Sep 16, 2019

Copy link
Copy Markdown
Member

Yeah, I wondered about this too, why do we need exports when we don't provide a lib?

@Siedlerchr Siedlerchr merged commit 15c3d99 into master Sep 16, 2019
@Siedlerchr Siedlerchr deleted the moduleExport branch September 16, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasdiez @calixtus @Siedlerchr