SilverPlatterImporterTest by tschechlovdev · Pull Request #510 · JabRef/jabref

tschechlovdev · 2015-12-14T20:54:37Z

No description provided.

oscargus · 2015-12-15T14:45:43Z

Seems to be some line ending issues here as well.

koppor · 2015-12-17T12:06:48Z

Please do the usual git fetch --all --prune, git merge upstream/master, git reset upstream/master, forced push (via git gui) cycle to generate one commit. This eases reviewing. We do NOT have the man power to review 5 or more separate commits.

This should also solve the failing build.

koppor · 2015-12-21T16:20:58Z

Coverage 90,74%. Please try to increase it.

koppor · 2015-12-27T23:21:08Z

Coverage is now 96,22%. The missed lines are mostly for incomplete entries (pages and title in chapters). Think, it's OK to miss them.

tobiasdiez · 2015-12-28T10:57:57Z

The if statement is not necessary.

tobiasdiez · 2016-02-15T22:34:23Z

+  author =   {Supek-S and Aine-CJ},
+  title =    {Simulation studies of multiple dipole neuromagnetic source localization, model order and limits of source resolution. },
+  year =     {1993},
+  volume =   {40(6) },


Volume should be just 40(6) without the space (i.e add trim() in importer)

Ideally 40(6) should be split to volume={40} and issue={6}.

stefan-kolb · 2016-04-06T18:15:40Z

What is the status here?

tschechlovdev · 2016-04-06T19:00:50Z

I'm waiting for feedback, wether the test is ok now.

tobiasdiez · 2016-04-06T19:11:55Z

+            Assert.assertEquals("many-much-more-i don't know", entries.get(0).getField("keywords"));
+            Assert.assertEquals("Gymnasium Unterrieden", entries.get(0).getField("school"));
+            Assert.assertEquals("Supek-S and Aine-CJ", entries.get(0).getField("editor"));
+            Assert.assertEquals("IEEE Trans Biomed Eng", entries.get(0).getField("journal"));


Better use the BibTexAssert.assertEquals(Collections.singletonList(shouldBeEntry), entries). See the other PRs

tobiasdiez · 2016-04-06T19:14:56Z

LGTM 👍 just some very small comments

tschechlovdev · 2016-04-06T20:32:25Z

I've added the comments.
But the tests fail, because of an AssertionError in testImportEntries2(): expected <1> but was <0>.
This error comes from BibtexEntryAssert.assertEquals(). But I checked wether the size of the list is 1 with Assert.assertEquals() and that seems to be ok. So I don't know why this error is comming.

tobiasdiez · 2016-04-06T20:50:46Z

+keywords = {many-much-more-i don't know},
+school = {Gymnasium Unterrieden},
+editor = {Supek-S and Aine-CJ},
+title = {imulation studies of multiple dipole neuromagnetic "\},


why is the rest of the title deleted in comparison to the txt file?

The title will only be saved till an " in comes. The code herefore is
int inPos = title.indexOf("\" in "); if (inPos > 1) { h.put("title", title.substring(1, inPos)); }
in the SilverplatterImporter.
If there isn't " in in the title then the whole title is saved.

tobiasdiez · 2016-04-06T20:54:41Z

The corresponding line is Assert.assertEquals(1, result.getDatabase().getEntryCount()); so there is a problem while parsing the bib file and not of the importer. Does opening the bibfile in JabRef works?

tschechlovdev · 2016-04-06T21:23:36Z

No it doesn't works. It says, that no entries were found.

tschechlovdev · 2016-04-06T22:17:24Z

I found the problem. Now the import of the bib file works. I also changed the test to a parameterized test.

simonharrer · 2016-04-07T07:36:01Z

+    @Test
+    public final void testIsRecognizedFormat() throws Exception {
+            try (InputStream stream = SilverPlatterImporterTest.class
+.getResourceAsStream(txtName)) {


wrong indent

simonharrer · 2016-04-07T07:37:30Z

Except my very minor comments 👍 LGTM

tschechlovdev · 2016-04-07T08:20:56Z

I adressed the comments and squashed all commits into one commit.

simonharrer · 2016-04-07T09:06:43Z

🏆

simonharrer added stupro labels Dec 14, 2015

tschechlovdev force-pushed the SilverPlatterImporterTest branch from 44250f4 to 2ecedcc Compare December 16, 2015 10:47

tschechlovdev force-pushed the SilverPlatterImporterTest branch 3 times, most recently from 11ce039 to 65e35bb Compare December 21, 2015 14:44

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 21, 2015

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 21, 2015

tschechlovdev force-pushed the SilverPlatterImporterTest branch from 65e35bb to c35a2e6 Compare December 21, 2015 18:48

tobiasdiez reviewed Dec 28, 2015
View reviewed changes

tschechlovdev changed the title ~~Silver platter importer test~~ SilverPlatterImporterTest Jan 7, 2016

koppor changed the title ~~SilverPlatterImporterTest~~ [WIP] SilverPlatterImporterTest Jan 15, 2016

tschechlovdev force-pushed the SilverPlatterImporterTest branch 3 times, most recently from 00bbd96 to 275b143 Compare January 25, 2016 15:58

tschechlovdev changed the title ~~[WIP] SilverPlatterImporterTest~~ SilverPlatterImporterTest Jan 25, 2016

tschechlovdev force-pushed the SilverPlatterImporterTest branch 3 times, most recently from 506515f to 81ded75 Compare January 26, 2016 17:05

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 15, 2016

tobiasdiez reviewed Feb 15, 2016
View reviewed changes

stefan-kolb mentioned this pull request Mar 30, 2016

Importer for Pubmed nbib format #1063

Closed

ayanai1 force-pushed the SilverPlatterImporterTest branch from 71a4660 to f82a6e6 Compare March 30, 2016 19:36

tschechlovdev added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 6, 2016

tobiasdiez reviewed Apr 6, 2016
View reviewed changes

tschechlovdev removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 6, 2016

tschechlovdev force-pushed the SilverPlatterImporterTest branch from f82a6e6 to 333a9a1 Compare April 6, 2016 20:12

tschechlovdev changed the title ~~SilverPlatterImporterTest~~ [WIP]SilverPlatterImporterTest Apr 6, 2016

tobiasdiez reviewed Apr 6, 2016
View reviewed changes

tschechlovdev changed the title ~~[WIP]SilverPlatterImporterTest~~ SilverPlatterImporterTest Apr 6, 2016

tschechlovdev added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 6, 2016

simonharrer reviewed Apr 7, 2016
View reviewed changes

add test for SilverplatterImporter

5cd10ee

tschechlovdev force-pushed the SilverPlatterImporterTest branch from 6b2bc3e to 5cd10ee Compare April 7, 2016 08:13

simonharrer merged commit d8ae5d7 into JabRef:master Apr 7, 2016

tschechlovdev deleted the SilverPlatterImporterTest branch April 7, 2016 09:10

koppor mentioned this pull request Aug 6, 2024

Make path relative after BibTeX-from-PDF import #11576

Merged

6 tasks

Uh oh!

Conversation

tschechlovdev commented Dec 14, 2015

Uh oh!

oscargus commented Dec 15, 2015

Uh oh!

koppor commented Dec 17, 2015

Uh oh!

koppor commented Dec 21, 2015

Uh oh!

koppor commented Dec 27, 2015

Uh oh!

tobiasdiez Dec 28, 2015

Choose a reason for hiding this comment

Uh oh!

tobiasdiez Feb 15, 2016

Choose a reason for hiding this comment

Uh oh!

oscargus Feb 16, 2016

Choose a reason for hiding this comment

Uh oh!

stefan-kolb commented Apr 6, 2016

Uh oh!

tschechlovdev commented Apr 6, 2016

Uh oh!

tobiasdiez Apr 6, 2016

Choose a reason for hiding this comment

Uh oh!

tobiasdiez commented Apr 6, 2016

Uh oh!

tschechlovdev commented Apr 6, 2016

Uh oh!

tobiasdiez Apr 6, 2016

Choose a reason for hiding this comment

Uh oh!

tschechlovdev Apr 6, 2016

Choose a reason for hiding this comment

Uh oh!

tobiasdiez commented Apr 6, 2016

Uh oh!

tschechlovdev commented Apr 6, 2016

Uh oh!

tschechlovdev commented Apr 6, 2016

Uh oh!

simonharrer Apr 7, 2016

Choose a reason for hiding this comment

Uh oh!

simonharrer commented Apr 7, 2016

Uh oh!

tschechlovdev commented Apr 7, 2016

Uh oh!

simonharrer commented Apr 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants