Add copy linked files action to contextmneu in general tab#5068
Merged
Conversation
tobiasdiez
requested changes
Jun 21, 2019
| @FXML private ListView<LinkedFileViewModel> listView; | ||
|
|
||
| @Inject private StateManager stateManager; | ||
| private final DialogService dialogService; |
Member
Author
There was a problem hiding this comment.
I actually tried to inject the other stuff as well, but the key problem is that the fxml loader requires the viewModel to be intiialized beforehand cause in the fxml there is an expression on the viewModel defined. And in the ctor the Injects stuff is of course still null.
Refactor preferences parameter Remove unsused parameter from dialog
Member
Author
|
Added a variant for a single entry and did some refactoring. |
tobiasdiez
requested changes
Jun 29, 2019
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Looks good to me now. Just some minor remarks
| .build(); | ||
| Optional<Path> exportPath = dialogService.showDirectorySelectionDialog(dirDialogConfiguration); | ||
| exportPath.ifPresent(this::copyFileToDestination); | ||
|
|
| private void copyFileToDestination(Path exportPath) { | ||
| Optional<Path> fileToExport = linkedFile.findIn(databaseContext, Globals.prefs.getFilePreferences()); | ||
|
|
||
| Optional<Path> newPath = OptionalUtil.combine(Optional.of(exportPath), fileToExport, resolvePathFilename); |
Member
There was a problem hiding this comment.
I think this is a bit overly complicated as we can only copy the file if we find it (e.g. fileToExport is not empty). Moreover, please show a warning in case it is empty.
| Globals.TASK_EXECUTOR, | ||
| dialogService, | ||
| JabRefPreferences.getInstance(), ExternalFileTypes.getInstance()); | ||
| JabRefPreferences.getInstance().getXMPPreferences(),JabRefPreferences.getInstance().getFilePreferences(), ExternalFileTypes.getInstance()); |
Member
There was a problem hiding this comment.
please put them on new lines as the other dependencies
…Contextmenu * upstream/master: (21 commits) Bump junit-vintage-engine from 5.4.2 to 5.5.0 Bump log4j-api from 2.11.2 to 2.12.0 Bump junit-platform-launcher from 1.4.2 to 1.5.0 Bump log4j-core from 2.11.2 to 2.12.0 Bump log4j-slf4j18-impl from 2.11.2 to 2.12.0 Bump log4j-jul from 2.11.2 to 2.12.0 Bump junit-jupiter from 5.4.2 to 5.5.0 Bump com.github.johnrengelman.shadow from 5.0.0 to 5.1.0 Bump log4j-jcl from 2.11.2 to 2.12.0 Bump fontbox from 2.0.15 to 2.0.16 (#5080) Bump pdfbox from 2.0.15 to 2.0.16 (#5081) Bump xmpbox from 2.0.15 to 2.0.16 (#5082) Update FUNDING.yml Delete autoapproval.yml Bump com.install4j.gradle from 7.0.11 to 7.0.12 (#5077) Configure autoapproval plugin for dependabot Bump xmlunit-matchers from 2.6.2 to 2.6.3 (#5074) Bump checkstyle from 8.21 to 8.22 (#5072) Bump xmlunit-core from 2.6.2 to 2.6.3 (#5073) Refactor for loop to stream in groupTree Close version socket ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5066