Followup of #4784 - fixes remaining issues of #4762#4806
Merged
Conversation
Siedlerchr
reviewed
Mar 24, 2019
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Just a minor issue, otherwise lgtm
| // Add changePane in case a file is present - otherwise just add the splitPane to the panel | ||
| Optional<File> file = bibDatabaseContext.getDatabaseFile(); | ||
| if (file.isPresent()) { | ||
| // create changeMonitor and changePane so we get notifications about outside changes to the file. |
Member
There was a problem hiding this comment.
Please use Path class, there should be a method getDatabasePath
* upstream/master: fix npe
Member
|
Thanks for the followup! Works fine now! |
Member
Author
|
Thank you for the Path fix 😉 |
1 task
Member
|
Thanks for fixing my mess! Much appreciated ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining problems mentioned in #4784 (review):
--
Change in CHANGELOG.md describedTests created for changesScreenshots added in PR description (for bigger UI changes)Check documentation status (Issue created for outdated help page at help.jabref.org?)