Skip to content

Checkstyle: force braces around code blocks#4387

Merged
LinusDietz merged 4 commits into
masterfrom
checkstyleBraces
Oct 28, 2018
Merged

Checkstyle: force braces around code blocks#4387
LinusDietz merged 4 commits into
masterfrom
checkstyleBraces

Conversation

@tobiasdiez

Copy link
Copy Markdown
Member

Enforces that code blocks are surrounded by braces, e.g. the following is invalid

if (test)
    statement;
else 
    statement;

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Enforces that code blocks are surrounded by braces, e.g. the following is invalid
```java
if (test)
    statement;
else 
    statement;
```

@LinusDietz LinusDietz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much agree with this PR. Side note: This relates to the comparison "Always use Braces" from Java by Comparison.

@LinusDietz

Copy link
Copy Markdown
Member

I fixed the violations in another PR, so we need to merge that one first: #4400

@LinusDietz LinusDietz merged commit 05047f3 into master Oct 28, 2018
@LinusDietz LinusDietz deleted the checkstyleBraces branch October 28, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants