Streamline formatter implementation#4044
Merged
Merged
Conversation
…plemented the same way
Member
|
Why not adding the methods implemented to the interface? |
Member
Author
|
|
Member
|
Why not make |
Member
Author
|
If this get merged, please with normal merge. Then the target branch of #4045 has to be changed to |
Member
Author
|
@stefan-kolb introduced the interface paradigma for formatters in 2015. The interface resides in our model package, whereas the concrete implementations reside in the logic package. In c09e472, I changed the interface to an abstract class. |
tobiasdiez
reviewed
May 23, 2018
| assertFalse(getFormatters().collect(Collectors.groupingBy( | ||
| formatter -> formatter.getKey(), | ||
| Collectors.counting() | ||
| )).entrySet().stream().anyMatch(e -> e.getValue() > 1)); |
Member
There was a problem hiding this comment.
In case somebody adds a new formatter with the same key, this test fails but the error message does not say why. I would change anyMatch to filter and compare (assertEquals) the resulting map to an empty map.
tobiasdiez
approved these changes
May 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #4043 and streamlines the code of the "formatter" framework a bit.
hashCodeandequalsare implemented the same waygetKey()returns a unique key