Skip to content

fixed issue 298#3726

Merged
lenhard merged 3 commits into
JabRef:comment-tabfrom
grotepfn:patch-3
Feb 16, 2018
Merged

fixed issue 298#3726
lenhard merged 3 commits into
JabRef:comment-tabfrom
grotepfn:patch-3

Conversation

@grotepfn

@grotepfn grotepfn commented Feb 15, 2018 •
edited
Loading

Copy link
Copy Markdown

fixed issue 298

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Credit (for an exercise):
Florian Grotepaß

tobiasdiez
tobiasdiez requested changes Feb 15, 2018
View reviewed changes

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the capitalization in the changelog to proper English sentence case. Apart from this, +1 for merge.

@Siedlerchr

Siedlerchr commented Feb 15, 2018

Copy link
Copy Markdown
Member

For future PRs you should specify a short title describing the content of the PR.
(github takes the title from the first line of the commit)
In the body of the PR you should add Fixes #xxx then github will close the corresponding issue (if it's in the main repo) automatically

lenhard
lenhard approved these changes Feb 16, 2018
View reviewed changes

@lenhard lenhard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. For the record, this is the issue we are talking about: JabRef#298

Next time, just use the link so that github can make the connection.

I am merging now.

@lenhard lenhard merged commit 4828955 into JabRef:comment-tab Feb 16, 2018
@lenhard lenhard mentioned this pull request Feb 16, 2018
Closed
@lenhard

lenhard commented Feb 16, 2018

Copy link
Copy Markdown
Member

After merging, I realized that this PR did not build on master. The branch this built on will eventually also be merged into master, which will get the change in. Nevertheless, with an issue like this there is no reason to base on a branch different from master.

Next time, please make sure that you base on master.

@koppor

koppor commented Feb 16, 2018

Copy link
Copy Markdown
Member

The changelog should be

... [koppor#298](https://github.com/koppor/jabref/issues/298)

No space and koppor in front. We will fix that in master as soon as comment-tab is merged :)

Nevertheless thank you for the quick action taken @grotepfn. Hope to see another issue fixed.

@koppor koppor added the PE1718 label Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasdiez tobiasdiez tobiasdiez requested changes

+1 more reviewer

@lenhard lenhard lenhard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@grotepfn @Siedlerchr @lenhard @koppor @tobiasdiez