Skip to content

Add Facebook and Twitter icons to the toolbar#3636

Merged
koppor merged 1 commit into
masterfrom
twitter
Jan 16, 2018
Merged

Add Facebook and Twitter icons to the toolbar#3636
koppor merged 1 commit into
masterfrom
twitter

Conversation

@koppor

@koppor koppor commented Jan 15, 2018

Copy link
Copy Markdown
Member

Before:

before

After:

after

  • Also add entry "Twitter" to "JabRef resources"
  • Put "Opens JabRef's X page" together in JabRef_*.properties

Does not connect to Twitter directly, thus no spying by Twitter, Facebook, ... Refs https://www.heise.de/newsticker/meldung/Datenschutz-und-Social-Media-Der-c-t-Shariff-ist-im-Einsatz-2470103.html


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 15, 2018

@LinusDietz LinusDietz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, can be merged afterwards.

private final AbstractAction forkMeOnGitHubAction = new OpenBrowserAction("https://github.com/JabRef/jabref",
Localization.menuTitle("Fork me on GitHub"), Localization.lang("Opens JabRef's GitHub page"), IconTheme.JabRefIcon.GITHUB.getSmallIcon(), IconTheme.JabRefIcon.GITHUB.getIcon());
private final AbstractAction donationAction = new OpenBrowserAction("https://github.com/JabRef/jabref/wiki/Donations",
private final AbstractAction donationAction = new OpenBrowserAction("https://dontaions.jabref.org",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Also add to "JabRef resources"
- Put "Opens JabRef's X page" together in JabRef_*.properties
@koppor koppor merged commit b00f907 into master Jan 16, 2018
@koppor koppor deleted the twitter branch January 16, 2018 14:34
@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 20, 2018
@koppor koppor mentioned this pull request Feb 20, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants