Adapt localization.gradle to python 3 by LinusDietz · Pull Request #3415 · JabRef/jabref

LinusDietz · 2017-11-08T12:44:53Z

lenhard · 2017-11-09T08:16:14Z

I just checkout this branch, ran ./gradlew localizationUpdate and got the following error:

FAILURE: Build failed with an exception.                       
                                                               
* Where:                                                       
Build file 'C:\workspaces\jabref\jabref\build.gradle' line: 30 
                                                               
* What went wrong:                                             
A problem occurred evaluating script.                          
> A problem occurred starting process 'command 'python3''

So this seems to not to be working yet.

Oh and here is the exception:

* Exception is:                                                                 
org.gradle.api.GradleScriptException: A problem occurred evaluating script.     
        at org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptR
unnerImpl.run(DefaultScriptRunnerFactory.java:92)                               
        at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl$
2.run(DefaultScriptPluginFactory.java:209)                                      
        at org.gradle.configuration.DefaultScriptTarget.addConfiguration(Default
ScriptTarget.java:74)                                                           
        at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl.
apply(DefaultScriptPluginFactory.java:214)                                      
        at org.gradle.configuration.BuildOperationScriptPlugin$1.run(BuildOperat
ionScriptPlugin.java:61)                                                        
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(De
faultBuildOperationExecutor.java:199)                                           
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(Defaul
tBuildOperationExecutor.java:110)                                               
        at org.gradle.configuration.BuildOperationScriptPlugin.apply(BuildOperat
ionScriptPlugin.java:58)                                                        
        at org.gradle.api.internal.plugins.DefaultObjectConfigurationAction.appl
yScript(DefaultObjectConfigurationAction.java:109)                              
        at org.gradle.api.internal.plugins.DefaultObjectConfigurationAction.acce
ss$000(DefaultObjectConfigurationAction.java:38)                                
        at org.gradle.api.internal.plugins.DefaultObjectConfigurationAction$1.ru
n(DefaultObjectConfigurationAction.java:68)                                     
        at org.gradle.api.internal.plugins.DefaultObjectConfigurationAction.exec
ute(DefaultObjectConfigurationAction.java:143)                                  
        at org.gradle.api.internal.project.AbstractPluginAware.apply(AbstractPlu
ginAware.java:46)                                                               
        at org.gradle.api.internal.project.ProjectScript.apply(ProjectScript.jav
a:34)                                                                           
        at org.gradle.api.Script$apply.callCurrent(Unknown Source)              
        at build_d7rpqa8h34dp26tukemi60cd3.run(C:\workspaces\jabref\jabref\build
.gradle:30)                                                                     
        at org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptR
unnerImpl.run(DefaultScriptRunnerFactory.java:90)                               
        at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl$
2.run(DefaultScriptPluginFactory.java:209)                                      
        at org.gradle.configuration.ProjectScriptTarget.addConfiguration(Project
ScriptTarget.java:77)                                                           
        at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl.
apply(DefaultScriptPluginFactory.java:214)                                      
        at org.gradle.configuration.BuildOperationScriptPlugin$1.run(BuildOperat
ionScriptPlugin.java:61)                                                        
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(De
faultBuildOperationExecutor.java:199)                                           
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(Defaul
tBuildOperationExecutor.java:110)                                               
        at org.gradle.configuration.BuildOperationScriptPlugin.apply(BuildOperat
ionScriptPlugin.java:58)                                                        
        at org.gradle.configuration.project.BuildScriptProcessor.execute(BuildSc
riptProcessor.java:41)                                                          
        at org.gradle.configuration.project.BuildScriptProcessor.execute(BuildSc
riptProcessor.java:26)                                                          
        at org.gradle.configuration.project.ConfigureActionsProjectEvaluator.eva
luate(ConfigureActionsProjectEvaluator.java:34)                                 
        at org.gradle.configuration.project.LifecycleProjectEvaluator.doConfigur
e(LifecycleProjectEvaluator.java:64)                                            
        at org.gradle.configuration.project.LifecycleProjectEvaluator.access$100
(LifecycleProjectEvaluator.java:34)                                             
        at org.gradle.configuration.project.LifecycleProjectEvaluator$ConfigureP
roject.run(LifecycleProjectEvaluator.java:110)                                  
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(De
faultBuildOperationExecutor.java:199)                                           
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(Defaul
tBuildOperationExecutor.java:110)                                               
        at org.gradle.configuration.project.LifecycleProjectEvaluator.evaluate(L
ifecycleProjectEvaluator.java:50)                                               
        at org.gradle.api.internal.project.DefaultProject.evaluate(DefaultProjec
t.java:656)                                                                     
        at org.gradle.api.internal.project.DefaultProject.evaluate(DefaultProjec
t.java:135)                                                                     
        at org.gradle.execution.TaskPathProjectEvaluator.configure(TaskPathProje
ctEvaluator.java:35)                                                            
        at org.gradle.execution.TaskPathProjectEvaluator.configureHierarchy(Task
PathProjectEvaluator.java:60)                                                   
        at org.gradle.configuration.DefaultBuildConfigurer.configure(DefaultBuil
dConfigurer.java:38)                                                            
        at org.gradle.initialization.DefaultGradleLauncher$ConfigureBuild.run(De
faultGradleLauncher.java:249)                                                   
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(De
faultBuildOperationExecutor.java:199)                                           
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(Defaul
tBuildOperationExecutor.java:110)                                               
        at org.gradle.initialization.DefaultGradleLauncher.configureBuild(Defaul
tGradleLauncher.java:167)                                                       
        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(Default
GradleLauncher.java:126)                                                        
        at org.gradle.initialization.DefaultGradleLauncher.executeTasks(DefaultG
radleLauncher.java:109)                                                         
        at org.gradle.internal.invocation.GradleBuildController$1.call(GradleBui
ldController.java:78)                                                           
        at org.gradle.internal.invocation.GradleBuildController$1.call(GradleBui
ldController.java:75)                                                           
        at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultW
orkerLeaseService.java:152)                                                     
        at org.gradle.internal.invocation.GradleBuildController.doBuild(GradleBu
ildController.java:100)                                                         
        at org.gradle.internal.invocation.GradleBuildController.run(GradleBuildC
ontroller.java:75)                                                              
        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(Exe
cuteBuildActionRunner.java:28)                                                  
        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildA
ctionRunner.java:35)                                                            
        at org.gradle.tooling.internal.provider.ValidatingBuildActionRunner.run(
ValidatingBuildActionRunner.java:32)                                            
        at org.gradle.launcher.exec.RunAsBuildOperationBuildActionRunner$1.run(R
unAsBuildOperationBuildActionRunner.java:43)                                    
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBu
ildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)              
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(De
faultBuildOperationExecutor.java:199)                                           
        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(Defaul
tBuildOperationExecutor.java:110)                                               
        at org.gradle.launcher.exec.RunAsBuildOperationBuildActionRunner.run(Run
AsBuildOperationBuildActionRunner.java:40)                                      
        at org.gradle.tooling.internal.provider.SubscribableBuildActionRunner.ru
n(SubscribableBuildActionRunner.java:51)                                        
        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProce
ssBuildActionExecuter.java:47)                                                  
        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProce
ssBuildActionExecuter.java:30)                                                  
        at org.gradle.launcher.exec.BuildTreeScopeBuildActionExecuter.execute(Bu
ildTreeScopeBuildActionExecuter.java:39)                                        
        at org.gradle.launcher.exec.BuildTreeScopeBuildActionExecuter.execute(Bu
ildTreeScopeBuildActionExecuter.java:25)                                        
        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.ex
ecute(ContinuousBuildActionExecuter.java:80)                                    
        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.ex
ecute(ContinuousBuildActionExecuter.java:53)                                    
        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter
.execute(ServicesSetupBuildActionExecuter.java:57)                              
        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter
.execute(ServicesSetupBuildActionExecuter.java:32)                              
        at org.gradle.tooling.internal.provider.GradleThreadBuildActionExecuter.
execute(GradleThreadBuildActionExecuter.java:36)                                
        at org.gradle.tooling.internal.provider.GradleThreadBuildActionExecuter.
execute(GradleThreadBuildActionExecuter.java:25)                                
        at org.gradle.tooling.internal.provider.ParallelismConfigurationBuildAct
ionExecuter.execute(ParallelismConfigurationBuildActionExecuter.java:43)        
        at org.gradle.tooling.internal.provider.ParallelismConfigurationBuildAct
ionExecuter.execute(ParallelismConfigurationBuildActionExecuter.java:29)        
        at org.gradle.tooling.internal.provider.StartParamsValidatingActionExecu
ter.execute(StartParamsValidatingActionExecuter.java:64)                        
        at org.gradle.tooling.internal.provider.StartParamsValidatingActionExecu
ter.execute(StartParamsValidatingActionExecuter.java:29)                        
        at org.gradle.tooling.internal.provider.SessionFailureReportingActionExe
cuter.execute(SessionFailureReportingActionExecuter.java:59)                    
        at org.gradle.tooling.internal.provider.SessionFailureReportingActionExe
cuter.execute(SessionFailureReportingActionExecuter.java:44)                    
        at org.gradle.tooling.internal.provider.SetupLoggingActionExecuter.execu
te(SetupLoggingActionExecuter.java:45)                                          
        at org.gradle.tooling.internal.provider.SetupLoggingActionExecuter.execu
te(SetupLoggingActionExecuter.java:30)                                          
        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBu
ild.java:67)                                                                    
        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(Build
CommandOnly.java:36)                                                            
        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(
DaemonCommandExecution.java:122)                                                
        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(
WatchForDisconnection.java:37)                                                  
        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(
DaemonCommandExecution.java:122)                                                
        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute
(ResetDeprecationLogger.java:26)                                                
        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(
DaemonCommandExecution.java:122)                                                
        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.
execute(RequestStopIfSingleUsedDaemon.java:34)                                  
        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(
DaemonCommandExecution.java:122)                                                
        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(Forw
ardClientInput.java:74)                                                         
        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(Forw
ardClientInput.java:72)                                                         
        at org.gradle.util.Swapper.swap(Swapper.java:38)                        
        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(For
wardClientInput.java:72)                                                        
        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(
DaemonCommandExecution.java:122)                                                
        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogA
ndCheckHealth.java:55)                                                          
        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(
DaemonCommandExecution.java:122)                                                
        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClien
t.java:62)                                                                      
        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(Build
CommandOnly.java:36)                                                            
        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(
DaemonCommandExecution.java:122)                                                
        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBu
ild(EstablishBuildEnvironment.java:82)                                          
        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(Build
CommandOnly.java:36)                                                            
        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(
DaemonCommandExecution.java:122)                                                
        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.
run(StartBuildOrRespondWithBusy.java:50)                                        
        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(Daemon
StateCoordinator.java:295)                                                      
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.
onExecute(ExecutorPolicy.java:63)                                               
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecu
torImpl.java:46)                                                                
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnabl
e.run(ThreadFactoryImpl.java:55)                                                
Caused by: org.gradle.process.internal.ExecException: A problem occurred startin
g process 'command 'python3''                                                   
        at org.gradle.process.internal.DefaultExecHandle.execExceptionFor(Defaul
tExecHandle.java:222)                                                           
        at org.gradle.process.internal.DefaultExecHandle.setEndStateInfo(Default
ExecHandle.java:202)                                                            
        at org.gradle.process.internal.DefaultExecHandle.failed(DefaultExecHandl
e.java:342)                                                                     
        at org.gradle.process.internal.ExecHandleRunner.run(ExecHandleRunner.jav
a:86)                                                                           
        at org.gradle.internal.operations.BuildOperationIdentifierPreservingRunn
able.run(BuildOperationIdentifierPreservingRunnable.java:39)                    
        ... 3 more                                                              
Caused by: net.rubygrapefruit.platform.NativeException: Could not start 'python3
'                                                                               
        at net.rubygrapefruit.platform.internal.DefaultProcessLauncher.start(Def
aultProcessLauncher.java:27)                                                    
        at net.rubygrapefruit.platform.internal.WindowsProcessLauncher.start(Win
dowsProcessLauncher.java:22)                                                    
        at net.rubygrapefruit.platform.internal.WrapperProcessLauncher.start(Wra
pperProcessLauncher.java:36)                                                    
        at org.gradle.process.internal.ExecHandleRunner.run(ExecHandleRunner.jav
a:68)                                                                           
        ... 4 more                                                              
Caused by: java.io.IOException: Cannot run program "python3" (in directory "C:\w
orkspaces\jabref\jabref"): CreateProcess error=2, The system cannot find the fil
e specified                                                                     
        at net.rubygrapefruit.platform.internal.DefaultProcessLauncher.start(Def
aultProcessLauncher.java:25)                                                    
        ... 7 more                                                              
Caused by: java.io.IOException: CreateProcess error=2, The system cannot find th
e file specified                                                                
        ... 8 more

LinusDietz · 2017-11-09T08:24:31Z

Well, do you have python3 installed?I know, the solution before with jython was more elegant.The problem is: it doesn't support python3, meaning that it must be pre installed on the user's machine. If this is an infeasible option, I would have to Port it back to a jython-supported version.

lenhard · 2017-11-09T08:30:40Z

Ok, I wasn't aware of that. In that case, I am strongly for reverting the changes and going back to the old localization script. Forcing people to install additional dependencies defeats the whole point of using a build system. Everything should be doable with only Java installed so that you can run gradle.

This would also make contributions for new users so much harder.

@JabRef/developers We need a decision on this.

LinusDietz · 2017-11-09T11:37:02Z

Check out #3420 in favor of this.

LinusDietz added 5 commits November 8, 2017 13:34

adapt localization.gradle

3ae0b07

More expressive exception

f22049c

Fix (?) circle CI build

c32861f

Add python versions to travis, install pyenv on circleci

13a5bed

Remove pypy from circle ci version, debug travis

75aa4bf

LinusDietz changed the title ~~Adapt localization.gradle to python 3~~ [WIP] Adapt localization.gradle to python 3 Nov 8, 2017

LinusDietz and others added 6 commits November 8, 2017 14:27

oh, really? i forgot some quotes

8f79d2f

Try travis with pyenv

8401970

Give it a try with two languages...

4eab119

Give it a try with two languages... 2

863233e

Give it a try with two languages... 3

7dafcec

remove empty line

1cc2a25

LinusDietz added dev: build-system component: internationalization i18n status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Nov 8, 2017

LinusDietz changed the title ~~[WIP] Adapt localization.gradle to python 3~~ Adapt localization.gradle to python 3 Nov 8, 2017

LinusDietz requested a review from koppor November 8, 2017 14:25

Siedlerchr approved these changes Nov 8, 2017

View reviewed changes

LinusDietz mentioned this pull request Nov 9, 2017

Backport of syncLang to python2 #3420

Merged

LinusDietz closed this Nov 9, 2017

stefan-kolb deleted the fix-gradle-localization branch February 6, 2018 10:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adapt localization.gradle to python 3#3415

Adapt localization.gradle to python 3#3415
LinusDietz wants to merge 11 commits into
masterfrom
fix-gradle-localization

LinusDietz commented Nov 8, 2017

Uh oh!

lenhard commented Nov 9, 2017 •

edited

Loading

Uh oh!

LinusDietz commented Nov 9, 2017 via email •

edited

Loading

Uh oh!

lenhard commented Nov 9, 2017 •

edited

Loading

Uh oh!

LinusDietz commented Nov 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

LinusDietz commented Nov 8, 2017

Uh oh!

lenhard commented Nov 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LinusDietz commented Nov 9, 2017 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lenhard commented Nov 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LinusDietz commented Nov 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lenhard commented Nov 9, 2017 •

edited

Loading

LinusDietz commented Nov 9, 2017 via email •

edited

Loading

lenhard commented Nov 9, 2017 •

edited

Loading