Fix initialization using injection context for complex objects#3334
Closed
tobiasdiez wants to merge 2 commits into
Closed
Fix initialization using injection context for complex objects#3334tobiasdiez wants to merge 2 commits into
tobiasdiez wants to merge 2 commits into
Conversation
Member
|
Why don't we create a fork of the original project and include other fixes as well, e.g. the system errr output (there is already a Pr regarding that) |
Member
|
The problem here is the license. We cannot just copy the code and use it here, because it is licensed differently. We will need to go for a fork / separate library. @koppor will contact the author of afterburner per mail. Maybe this wakes him up. |
Member
Author
|
I really like license problems :-). I would actually help Adam Bien to maintain this library. I think, of now JabRef is one of the main users of afterburner and thus we should be interested in having a stable and working platform. (I don't like a separate fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to help @Siedlerchr, I fixed a bug in the framework which we use to inject dependencies in the javafx controller. I proposed a PR AdamBien/afterburner.fx#80 but as he is a bit slow with integrating fixes, I think we should directly include the fix in JabRef for the moment (and remove it as soon as a new version of afterburner.fx with the fix is released).
gradle localizationUpdate?